[jb] Add support for JetBrains IDEs v2022.3 #13044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
force-pushed
the
vn/jetbrains-backend-plugin-223
branch
from
7a561cf to
0c59278
Compare
felladrin
force-pushed
the
vn/jetbrains-backend-plugin-223
branch
3 times, most recently
from
dd0f5fa to
bc95669
Compare
felladrin
commented
Sep 27, 2022
Comment on lines
+72
to
+76
| GlobalScope.launch { | ||
| withContext(Dispatchers.IO) { | ||
| CommandLineProcessor.doOpenFileOrProject(file, shouldWait).future.get() | ||
| } | ||
| } |
There was a problem hiding this comment.
ℹ️ This change is because this became a suspend function in 2022.3.
felladrin
commented
Sep 27, 2022
| @@ -120,7 +120,9 @@ class GitpodClientProjectSessionTracker( | |||
|
|
|||
| // Ignore ports that aren't actually used by the user (e.g. ports used internally by JetBrains IDEs) | |||
| val backendPort = BuiltInServerManager.getInstance().waitForStart().port | |||
| val serverPort = StartupUtil.getServerFuture().await().port | |||
There was a problem hiding this comment.
ℹ️ This change is because com.intellij.idea.StartupUtil doesn't exist anymore in 2022.3.
felladrin
commented
Sep 27, 2022
Comment on lines
+94
to
+96
| val isForwarded = forwardedPortsList.find { it.hostPort == hostPort } != null | ||
|
|
||
| if (isServed && !forwardedPortsList.containsKey(hostPort)) { | ||
| if (isServed && !isForwarded) { |
There was a problem hiding this comment.
ℹ️ This was changed because forwaredPortsList became a List instead of a Map in v2022.3.
felladrin
force-pushed
the
vn/jetbrains-backend-plugin-223
branch
2 times, most recently
from
5414a1b to
3c4e378
Compare
felladrin
force-pushed
the
vn/jetbrains-backend-plugin-223
branch
from
3c4e378 to
eb11a75
Compare
felladrin
force-pushed
the
vn/jetbrains-backend-plugin-223
branch
from
eb11a75 to
1c546fb
Compare
|
Closed in favor of #13400, which is based on a previous commit and should have the Preview Environment working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that IDEA/PyCharm/PhpStorm/GoLand latest version is v2022.3 in Gitpod, we can add support for JetBrains IDEs v2022.3.
All code changes were done to accommodate the API differences between v2022.2 and v2022.3. There were no logic/flow changes in the plugin.
How to test
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide