Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force all the values redacted once one of the values matches redact fields #13046

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Force all the values redacted once one of the values matches redact fields #13046

merged 1 commit into from
Sep 17, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Sep 16, 2022 •
edited
Loading

Description

Since the map ordering is random, not by sequence or alphabetical order. Thank @svenefftinge points out.
So, we have to force all the values redacted once one of the values matches redact fields

Related Issue(s)

Fixes https://github.com/gitpod-io/security/issues/64

How to test

Check the unit test.

cd component/common-go

# keep re-run this multiple times to make sure all test pass
go test -covermode atomic -run ^TestRedactJSON\$ github.com/gitpod-io/gitpod/common-go/log -timeout=60s -count=1 -race -v

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

@jenting
Force all the values redacted once one of the values matches redact f…
c3d3889 
…ields

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting requested review from a team September 16, 2022 14:28
@jenting jenting self-assigned this Sep 16, 2022
@jenting jenting removed their assignment Sep 16, 2022
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Sep 16, 2022
svenefftinge
svenefftinge approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 fair enough!

@geropl
Copy link
Member

geropl commented Sep 16, 2022

/hold

@kylos101
Copy link
Contributor

@jenting as a heads up, there is a ws-manager test failure:

[components/ws-manager:app]     --- FAIL: TestModifyFinalizer/add_finalizer_noop (21.92s)

@jenting
Copy link
Contributor Author

jenting commented Sep 17, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jenting-64.9
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Sep 17, 2022

The error is ETCD not up, it not related to this PR change.

Rerun build pass.

/unhold

@roboquat roboquat merged commit 13cccd8 into main Sep 17, 2022
@roboquat roboquat deleted the jenting/64 branch September 17, 2022 02:09
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jenting @geropl @kylos101 @svenefftinge @sagor999 @roboquat