Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] remove unused isBillingModeEnabled #13089

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[server] remove unused isBillingModeEnabled #13089

merged 1 commit into from
Sep 20, 2022

Conversation

svenefftinge
Copy link
Member

Description

Removes unused method and a feature flag for billing mode.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@svenefftinge svenefftinge requested a review from a team September 19, 2022 13:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 19, 2022
geropl
geropl approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the 🧹

build fails with: ee/src/workspace/gitpod-server-impl.ts(117,1): error TS6133: 'getExperimentsClientForBackend' is declared but its value is never read.

@roboquat roboquat added size/S and removed size/M labels Sep 20, 2022
@svenefftinge
Copy link
Member Author

svenefftinge commented Sep 20, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-remove-unused-flag.3
(with .werft/ from main)

@roboquat roboquat merged commit f00bf26 into main Sep 20, 2022
@roboquat roboquat deleted the se/remove-unused-flag branch September 20, 2022 13:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenefftinge @geropl @roboquat