[server][github] fix file provider for self-managed GHE

[AlexTugarev]

Description

This PR removes URL construction for reading file contents, instead rely on supported REST API.

Related Issue(s)

Fixes #9253

How to test

Though this claims to fix an GHE issue, it can be verified with GitHub SaaS as well, because the core issue was that we'd used to craft the download URL, but here we're changing to supported means of fetching contents via REST API. That said, if should be sufficient to test .gitpod.yml being read from any GitHub repo in a prebuild of a project.

Release Notes

Fix reading .gitpod.yml for self-managed GHE instances.

Documentation

Werft options:

• /werft with-preview
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[werft-gitpod-dev-com]

started the job as gitpod-build-alex-adjust-url-being-used-to-fetch-9253.0 because the annotations in the pull request description changed
(with .werft/ from main)

[werft-gitpod-dev-com]

started the job as gitpod-build-alex-adjust-url-being-used-to-fetch-9253.1 because the annotations in the pull request description changed
(with .werft/ from main)

[geropl]

@AlexTugarev During testing, while creating a project from my personal repo in GH, I see this error message:

As a result, the project seems to be there, but it does not receive any prebuild triggers... any idea why? 🤔

[AlexTugarev]

As a result, the project seems to be there, but it does not receive any prebuild triggers... any idea why? 🤔

Unfortunately, not.

I tried to reproduce with a fork of that repo, but it worked fine.

@geropl, please repeat, as I just enabled debug logging for server.

/hold

Because of this report, and I'm not able to tell if this is unrelate, though it seems. And because I forgot to remove dead code.

[geropl]

@AlexTugarev seeing this in the logs:

{
  "@type": "type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent",
  "serviceContext": {
    "service": "server",
    "version": "alex-adjust-url-being-used-to-fetch-9253.0"
  },
  "stack_trace": "GitHubApiError: GitHub API Error. Status: 422
    at GitHubRestApi.<anonymous> (/app/node_modules/@gitpod/server/dist/src/github/api.js:198:27)
    at Generator.throw (<anonymous>)
    at rejected (/app/node_modules/@gitpod/server/dist/src/github/api.js:20:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
  "component": "server",
  "severity": "ERROR",
  "time": "2022-09-20T12:33:47.225Z",
  "context": { "userId": "5c510231-73e4-4650-993d-644ba9b21745" },
  "message": "Request createProject failed with internal server error",
  "error": "GitHubApiError: GitHub API Error. Status: 422
    at GitHubRestApi.<anonymous> (/app/node_modules/@gitpod/server/dist/src/github/api.js:198:27)
    at Generator.throw (<anonymous>)
    at rejected (/app/node_modules/@gitpod/server/dist/src/github/api.js:20:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)",
  "payload": {
    "method": "createProject",
    "args": [
      {
        "name": "gitpod-test-repo",
        "slug": "gitpod-test-repo",
        "cloneUrl": "https://github.com/geropl/gitpod-test-repo.git",
        "teamId": "5b65b970-9b57-4857-a6f8-3c953f6d04d7",
        "appInstallationId": "undefined"
      },
      { "_isCancelled": false }
    ]
  }
}

[AlexTugarev]

@geropl, could you please try again and use a different repo? I guess your test repo had see a lot of webhooks already 🤷🏻‍♂️

The error event is likely fired from there, thus not related to this PR. Let's tell the issues apart 🙏🏻

[geropl]

With different repository I see prebuilds working as expected

/hold in case any other check is required 🙃

[AlexTugarev]

With different repository I see prebuilds working as expected

This is then subject to a bug with webhook installation on GH repos.

cc. @jankeromnes, in cause you've encountered 422 error codes before?

[AlexTugarev]

/hold cancel