Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[observability] add resources load failed ratio to code-browser #13137

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Sep 20, 2022

Description

Add resources load failed ratio to code-browser

Overview

image

Faster Link

image

Related Issue(s)

Fixes #

How to test

See https://grafana.gitpod.io/d/O6T-Pf7Vz/vs-code-browser-overview-mustard?orgId=1

Their JSON should be similar (ignore id and panel positon etc)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-loaderr-observe.2 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh mustard-mh marked this pull request as ready for review September 20, 2022 17:48
@mustard-mh mustard-mh requested a review from a team September 20, 2022 17:48
@mustard-mh mustard-mh marked this pull request as draft September 21, 2022 04:09
@akosyakov
Copy link
Member

I don't think we should break by clusters, but have overall ratio.

@mustard-mh mustard-mh marked this pull request as ready for review September 22, 2022 06:29
@@ -36,6 +36,121 @@
"x": 0,
"y": 0
},
"id": 21,
"panels": [],
"title": "Browser Workbench",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS Code Web Workbench

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh can you update the title and then let's merge, deploy and see in prod

@roboquat roboquat merged commit 90e3308 into main Sep 22, 2022
@roboquat roboquat deleted the hw/loaderr-observe branch September 22, 2022 11:08
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants