Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usage] Use DefaultClientOptions when creating grpc client connection #13167

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 21, 2022

Description

To re-use existing setup and configuration for grpc clients. We get uniformity and ability to better track metrics

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team September 21, 2022 11:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 21, 2022
@roboquat roboquat merged commit 0f5d689 into main Sep 23, 2022
@roboquat roboquat deleted the mp/usage-standard-grpc-client-opts branch September 23, 2022 07:22
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants