[installer-tests] make domain name configurable #13245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
nandajavarma
force-pushed
the
nvn/use-domains
branch
from
7cc708f to
da28131
Compare
adrienthebo
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Only applies to the eks job, but @nandajavarma and I have discussed this in slack.
/hold for AKS/GKE support, good otherwise
nandajavarma
force-pushed
the
nvn/use-domains
branch
from
da28131 to
1d56b06
Compare
|
Added support on all platforms. /unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Domain name configurable for self hosted installer tests. The main drive here is to still run the tests even after we hit the let's encrypt cert limits. This is a very tiny workaround. The domain we provide should be registered under CloudDNS under the project
dns-for-playgrounds(the project will change in the future) with a zone name same as the domain but.replaced by-. For eg, if the domain istests.doptig.com, it expects the domain to be registered under the nametests-doptig-com(this is how we currently do it underdns-for-playgroundsproject.Related Issue(s)
Fixes #
How to test
You can something like the following:
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide