Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] update stable browser code for error report #13252

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[code] update stable browser code for error report #13252

merged 1 commit into from
Sep 23, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Sep 23, 2022 •
edited
Loading

Description

Commit hash is from werft job

Bring error reporting gitpod-io/openvscode-server@139f4a4 to stable

Related Issue(s)

Fixes #

How to test

Tested in previous PR

Open workspace with stable code in prev env, check if commit hash in About page is equal to 968fb943b510de16a4c516886f6aa38ead65cb5c

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mustard-mh mustard-mh requested a review from a team September 23, 2022 16:41
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-stable-ep.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

/hold

@mustard-mh mustard-mh marked this pull request as draft September 23, 2022 16:54
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 23, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-hw-stable-ep.2
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 23, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-hw-stable-ep.3
(with .werft/ from main)

@mustard-mh mustard-mh marked this pull request as ready for review September 23, 2022 17:24
@mustard-mh
Copy link
Contributor Author

/unhold

Tested and works

About Error Report
image image

@mustard-mh mustard-mh requested a review from jeanp413 September 23, 2022 17:26
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 23, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Could you help give approval? 🙏 @filiptronicek

filiptronicek
filiptronicek approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ - kommit is korrekt
image

@roboquat roboquat merged commit 53b5b23 into main Sep 23, 2022
@roboquat roboquat deleted the hw/stable-ep branch September 23, 2022 18:12
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

@jeanp413 jeanp413 Awaiting requested review from jeanp413

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note-none size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustard-mh @filiptronicek @roboquat