Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Add gRPC Client dashboard with metrics #13264

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 24, 2022

Description

See dashboard in action here

The dashboard is the same as the existing gRPC / Server but with client-side metrics.
Currently latency is not being reported and hence no data showing up in the latency section.

Screenshot 2022-09-24 at 23 36 58

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested review from a team September 24, 2022 21:37
@github-actions github-actions bot added team: IDE team: devx team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Sep 24, 2022
@ArthurSens
Copy link
Contributor

ArthurSens commented Sep 24, 2022

it looks like you committed an empty file by mistake? 😅

@easyCZ
Copy link
Member Author

easyCZ commented Sep 24, 2022

/hold Thanks Arthur, yes I did. Looks like some issues with my IDE

@easyCZ
Copy link
Member Author

easyCZ commented Sep 24, 2022

Fixed the issue with empty file.
/unhold

@easyCZ easyCZ force-pushed the mp/dash-grpc-client branch from a0f7c15 to 0a6f984 Compare September 24, 2022 22:53
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@roboquat roboquat merged commit a9c85bd into main Sep 24, 2022
@roboquat roboquat deleted the mp/dash-grpc-client branch September 24, 2022 23:12
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/XXL team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants