[kots]: remove the "require min RBAC" boolean #13308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the preflight checks from being run in some environments (eg, EKS) as there are elevated privileges required to interrogate nodes etc
github-actions
bot
added
the
team: delivery
nandajavarma
approved these changes
Sep 26, 2022
|
/hold |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents the preflight checks from being run in some environments (eg, EKS) as there are elevated privileges required to interrogate nodes etc.
There was a misunderstanding from the KOTS docs made in #13168 which I thought created the
kotsadmservice account. This service account appears to always be created, but this boolean limits it's capabilities (in retrospect, that's obvious. But it wasn't at the time - we caught it before it was released to the public anyway).How to test
Deploy via KOTS on AWS. Preflight checks should run - previously, they were not running due to lack of cluster role permissions. With this fix, they should run.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide