Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Fix checkout local HEAD branch #13322

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[content-service] Fix checkout local HEAD branch #13322

merged 1 commit into from
Sep 27, 2022

Conversation

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-head.4 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Sep 26, 2022

/werft run

👍 started the job as gitpod-build-aledbf-head.5
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review September 27, 2022 01:03
@aledbf aledbf requested a review from a team September 27, 2022 01:03
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 27, 2022
@utam0k
Copy link
Contributor

utam0k commented Sep 27, 2022

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-aledbf-head.6
(with .werft/ from main)

We should pass this test case

{
// Branch name decisions are not tested in the workspace as it is the server side logic
Name: "open issue",
ContextURL: "github.com/gitpod-io/gitpod-test-repo/issues/88",
WorkspaceRoot: "/workspace/gitpod-test-repo",
},

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2022

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-aledbf-head.7
(with .werft/ from main)

@roboquat roboquat merged commit 57fdeaa into main Sep 27, 2022
@roboquat roboquat deleted the aledbf/head branch September 27, 2022 02:23
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note and removed release-note-none labels Sep 28, 2022
@atduarte
Copy link
Contributor

@aledbf added a release note as this is very relevant to the end user

@utam0k
Copy link
Contributor

utam0k commented Sep 28, 2022

@aledbf added a release note as this is very relevant to the end user

@atduarte
This is a fix for a problem that occurred in the refactoring, and from the user's point of view, there should be no change because we didn't release them. WDYT?

@atduarte
Copy link
Contributor

@utam0k ah, got it! Thanks for sharing. Will revert back. Sorry @aledbf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot open the workspace when open from the issue
5 participants