[refarch] Update node size for GCP and AWS #13356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
|
Hey @Furisto ! Thanks for this fix! I believe the following suggestion is an indicator that we should name the terraform modules better. The terraform setup corresponding to the Single cluster reference architecture is present here. In cluster.tf, you can see that the machine size is specified. We will have to update this value. The |
|
/hold Since this is a small change, there might be a tendency to get tit merged. Hence holding. See comment above |
Furisto
force-pushed
the
fo/sh-node-size
branch
from
729f3d7 to
4794229
Compare
|
@nandajavarma Thanks. Added the override for gke and eks. |
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the node size for GCP and AWS self hosted reference architectures as laid out in https://github.com/gitpod-io/website/pull/2790.
Related Issue(s)
Related to https://github.com/gitpod-io/website/pull/2790
How to test
Not sure, would appreciate some pointers.
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide