[server] Fix team deletion for non-UBP enabled teams #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-af-fix-sh-team-deletion.4 because the annotations in the pull request description changed |
jankeromnes
reviewed
Sep 28, 2022
Ensure that payment is enabled before attempting Stripe operations.
andrew-farries
force-pushed
the
af/fix-sh-team-deletion
branch
from
53123c3 to
77cce1c
Compare
jankeromnes
approved these changes
Sep 28, 2022
3 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Team deletion for non-UBP teams is currently broken. This PR fixes the issue by ensuring that we don't check for UBP specific details about the team (such as any currently active Stripe subscription) before ensuring that Stripe payments are enabled.
Related Issue(s)
Fixes #13392
How to test
Create a team in the preview environment and then delete it.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide