-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ws-manager: remove PVC object if the workspace pod fails to up #13429
Conversation
started the job as gitpod-build-jenting-13282.3 because the annotations in the pull request description changed |
61fb754
to
825bde4
Compare
started the job as gitpod-build-jenting-13282.6 because the annotations in the pull request description changed |
/werft run with-clean-slate-deployment with-large-vm 👍 started the job as gitpod-build-jenting-13282.7 |
Remove the PVC object if the stop workspace request. The PVC object removal is postponed until the PVC is no longer actively used by the workspace pod. Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting removed release notes as it seems this only directly benefits Gitpod operators not end users. |
@jenting: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Remove the PVC object if the workspace pod could not create or the workspace pod never reached a running state.
Related Issue(s)
Fixes #13282
How to test
for i in {1..110}; do kubectl run test-${i} --image ubuntu -- sleep 3600; done
Release Notes
Documentation
None
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide