Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws-manager: remove PVC object if the workspace pod fails to up #13429

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Sep 29, 2022

Description

Remove the PVC object if the workspace pod could not create or the workspace pod never reached a running state.

Related Issue(s)

Fixes #13282

How to test

  • Create 110 pods to reach the per-node max pod limit
    for i in {1..110}; do kubectl run test-${i} --image ubuntu -- sleep 3600; done
  • Enable PVC feature flag.
  • Create a workspace, and make sure the workspace pod failed to up.
  • Waits for 30 minutes, and the workspace pod is terminated and done.
  • The PVC object is gone as well.

Release Notes

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13282.3 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting force-pushed the jenting/13282 branch 2 times, most recently from 61fb754 to 825bde4 Compare September 29, 2022 06:35
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13282.6 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Sep 29, 2022

/werft run with-clean-slate-deployment with-large-vm

👍 started the job as gitpod-build-jenting-13282.7
(with .werft/ from main)

Remove the PVC object if the stop workspace request.
The PVC object removal is postponed until the PVC is no longer actively
used by the workspace pod.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting marked this pull request as ready for review October 3, 2022 13:07
@jenting jenting requested a review from a team October 3, 2022 13:07
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 3, 2022
@roboquat roboquat merged commit 28fae90 into main Oct 3, 2022
@roboquat roboquat deleted the jenting/13282 branch October 3, 2022 22:35
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 5, 2022
@atduarte
Copy link
Contributor

@jenting removed release notes as it seems this only directly benefits Gitpod operators not end users.

@roboquat
Copy link
Contributor

@jenting: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production do-not-merge/release-note-label-needed size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] orphan PVC left if the ws-manager unable to start workspace pod
4 participants