Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: if statements to switch statements in dashboard #13842

Merged
merged 3 commits into from
Oct 23, 2022
Merged

change: if statements to switch statements in dashboard #13842

merged 3 commits into from
Oct 23, 2022

Conversation

harshsinghatz
Copy link
Contributor

@harshsinghatz harshsinghatz commented Oct 13, 2022 •
edited by laushinka
Loading

Description

Changing multiple consecutive if statements to switch cases for better readability and cleaner code

Release Notes

NONE

Werft options:

  • /werft with-preview

@harshsinghatz harshsinghatz requested a review from a team October 13, 2022 13:18
@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@laushinka laushinka added the do-not-merge/cla-pending CLA has not been signed label Oct 18, 2022
@laushinka
Copy link
Contributor

laushinka commented Oct 18, 2022 •
edited
Loading

@harshsinghatz thanks for opening this PR. Would you mind signing this Contributor License Agreement (CLA) form? This is a one-time agreement for new contributors :)
Cc @meysholdt

@harshsinghatz
Copy link
Contributor Author

@laushinka Done!, I have signed the CLA

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-harsh-improve-code-flow-dashboard.0 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Oct 19, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-harsh-improve-code-flow-dashboard.2 because the annotations in the pull request description changed
(with .werft/ from main)

laushinka
laushinka approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @harshsinghatz!

@laushinka
Copy link
Contributor

laushinka commented Oct 19, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-harsh-improve-code-flow-dashboard-fork.0
(with .werft/ from main)

@laushinka
Copy link
Contributor

laushinka commented Oct 19, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@harshsinghatz Could you rebase to main? 🙏🏽

@meysholdt
Copy link
Member

Thank you for signing the CLA, @harshsinghatz!

@harshsinghatz
Copy link
Contributor Author

harshsinghatz commented Oct 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@harshsinghatz Could you rebase to main? 🙏🏽

Sorry missed the notification for some reason, can you guide on rebasing the branch on main

@laushinka
Copy link
Contributor

Sorry missed the notification for some reason, can you guide on rebasing the branch on main

@harshsinghatz No worries :) You can run git pull --rebase origin main and then git push -f Let me know if you run into any issues or conflicts.

@harshsinghatz harshsinghatz force-pushed the Harsh/improve-code-flow-dashboard branch from 907d572 to a9e53c6 Compare October 21, 2022 10:53
@harshsinghatz
Copy link
Contributor Author

Sorry missed the notification for some reason, can you guide on rebasing the branch on main

@harshsinghatz No worries :) You can run git pull --rebase origin main and then git push -f Let me know if you run into any issues or conflicts.

@laushinka Done!

@harshsinghatz
Copy link
Contributor Author

@laushinka Is there something else to do?

@laushinka
Copy link
Contributor

laushinka commented Oct 23, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-harsh-improve-code-flow-dashboard-fork.1
(with .werft/ from main)

@roboquat roboquat merged commit 1e4a310 into gitpod-io:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
cla: accepted ✔️ release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshsinghatz @laushinka @meysholdt @vulkoingim @roboquat