New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: feat: Enable and autoinstall shell completions for gp CLI #13887

Closed

axonasif wants to merge 1 commit into main from axonasif/gp_completion

Member

axonasif commented Oct 15, 2022 •

edited

Loading

Description

Glad I stumbled upon the codebase, I was literally about to write the completion scripts for use with my fish shell. It's kind of funny how this wasn't mentioned anywhere how to setup for bash, which was already there 😬
This updates the completion command and autoinstalls them for different shells on workspace start.

fish

bash

zsh

Related Issue(s)

Fixes #

How to test

Open a workspace in preview env
Type gp and hit Tab key.

To check for other shells, switch to them by running fish or zsh
And redo 2.

Release Notes

feat: Enable and autoinstall shell completions for gp CLI

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide

axonasif requested a review from a team

October 15, 2022 13:22

roboquat added do-not-merge/release-note-label-needed size/L labels

werft-gitpod-dev-com bot commented Oct 15, 2022

started the job as gitpod-build-axonasif-gp-completion.1 because the annotations in the pull request description changed
(with .werft/ from main)

github-actions bot added the team: IDE label

axonasif marked this pull request as draft

October 15, 2022 13:23

roboquat added the do-not-merge/work-in-progress label

axonasif changed the title ~~feat: Enable and autoinstall shell completions for gp CLI~~ Proposal: feat: Enable and autoinstall shell completions for gp CLI

roboquat added release-note and removed do-not-merge/release-note-label-needed labels

Member Author

axonasif commented Oct 15, 2022

Had to recreate the PR as werft was failing to boot a VM on an old PR.

Member Author

axonasif commented Oct 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run

👍 started the job as gitpod-build-axonasif-gp-completion.2
(with .werft/ from main)

Member Author

axonasif commented Oct 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-axonasif-gp-completion.3
(with .werft/ from main)

axonasif force-pushed the axonasif/gp_completion branch from 8b6bd13 to 24799bb Compare

October 15, 2022 15:24

Member Author

axonasif commented Oct 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-axonasif-gp-completion.7
(with .werft/ from main)

axonasif marked this pull request as ready for review

October 15, 2022 15:38

roboquat removed the do-not-merge/work-in-progress label

axonasif force-pushed the axonasif/gp_completion branch 3 times, most recently from e96afc9 to 4d60569 Compare

October 16, 2022 13:20

Member Author

axonasif commented Oct 16, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-axonasif-gp-completion.11
(with .werft/ from main)

axonasif added the priority: low (not urgent / proposal) label

Member Author

axonasif commented Oct 28, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-axonasif-gp-completion.12
(with .werft/ from main)

Member Author

axonasif commented Oct 28, 2022 •

edited by werft-gitpod-dev-com bot

Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-axonasif-gp-completion.13
(with .werft/ from main)


          feat: Enable and autoinstall shell completions for gp CLI

538c196

axonasif force-pushed the axonasif/gp_completion branch from 4d60569 to 538c196 Compare

October 28, 2022 13:40

axonasif closed this

axonasif deleted the axonasif/gp_completion branch

October 28, 2022 13:43

axonasif restored the axonasif/gp_completion branch

October 28, 2022 13:43

axonasif mentioned this pull request

proposal: feat: Enable and autoinstall shell completions for gp CLI #14258

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low (not urgent / proposal) release-note size/L team: IDE