[server] Don't fetch the repository config a second time when starting incremental prebuilds #13962
Conversation
jankeromnes
changed the title
roboquat
added
size/XS
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-jx-fetch-config.1 because the annotations in the pull request description changed |
|
Tested incremental prebuilds and they still work 🎉 |
| config?: WorkspaceConfig, | ||
| ): Promise<PrebuiltWorkspace | undefined> { | ||
| if (!history.commitHistory || history.commitHistory.length < 1) { | ||
| return; | ||
| } | ||
|
|
||
| const { config } = await this.configProvider.fetchConfig({}, user, context); | ||
| if (!config) { | ||
| config = (await this.configProvider.fetchConfig({}, user, context)).config; | ||
| } |
There was a problem hiding this comment.
We're always gonna fetch the config when it's not provided. Here, we can push that into caller and always require a config to be present on this call. The caller can do await this.configProvider.fetchConfig({}, user, context)).config to get it. It has the benefit of not hiding complexity and the method signature much better communicates the behaviour.
We only have another caller from gitpod-server-impl so it is a small change.
config: WorkspaceConfig,
): Promise<PrebuiltWorkspace | undefined> {
if (!history.commitHistory || history.commitHistory.length < 1) {
return;
}
There was a problem hiding this comment.
Good point, thanks for the idea 👍
There was a problem hiding this comment.
This implies injecting a ConfigProvider into GitpodServerImplEE, but I think that's okay and cleaner this way.
|
/hold for Milan's suggestion |
…g incremental prebuilds
jankeromnes
force-pushed
the
jx/fetch-config
branch
from
1a183fc to
e82d33e
Compare
|
Addressed /unhold |
roboquat
added
deployed: webapp
Description
Follow-up to #13801: Don't fetch the repository config a second time when starting incremental prebuilds
Related Issue(s)
Fixes #13801 (comment)
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide