Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Lean More" button behavior from JetBrains Gateway home screen #13966

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Oct 18, 2022

Description

Update Gitpod Gateway Connector to match the latest API.

This fixes the "Learn More"/"More" button behavior, on the home screen of JetBrains Gateway, so clicking them will open https://www.gitpod.io/docs/ides-and-editors/jetbrains-gateway on browser.

JetBrains Gatway Stable JetBrains Gateway EAP
image image

Related Issue(s)

Follow-up for #13948

How to test

  1. Download the Stable Build of the plugin from here, install it on Stable Gateway (2022.2) and check if the "Learn More" button works.
  2. Download the EAP Build of the plugin from here, install it on EAP Gateway (2022.3) and check if the "More" button works.

Release Notes

Fixed the "Learn More" button behavior from JetBrains Gateway home screen.

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

This fixes the "more" button behavior, on the home screen of JetBrains Gateway.
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected :)

Thanks for fixing this @felladrin 🎉

@roboquat roboquat merged commit 22dec18 into main Oct 19, 2022
@roboquat roboquat deleted the felladrin/update-gateway-connector-class branch October 19, 2022 13:29
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants