Skip to content

Re-add "Use Last Successful Prebuild" #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Oct 20, 2022

Description

In #13997, we randomly reverted a few changes in the hopes of resolving #13991.

However, it turns out that these changes were completely unrelated to the bug (internal source).

Thus, we can safely re-merge this PR that was already tested and approved.

Related Issue(s)

Part of #12582

How to test

See original PR

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jx-reland-last-successful-prebuild.1 because the annotations in the pull request description changed
(with .werft/ from main)

@jankeromnes jankeromnes changed the title Jx/reland last successful prebuild Remerge "Use Last Successful Prebuild" Oct 20, 2022
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 20, 2022

Insert 🪙 to try again 🎰

/werft run

👍 started the job as gitpod-build-jx-reland-last-successful-prebuild.2
(with .werft/ from main)

@jankeromnes jankeromnes force-pushed the jx/reland-last-successful-prebuild branch from 4efa1a8 to 09f9968 Compare October 20, 2022 09:02
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 20, 2022

/werft run

👍 started the job as gitpod-build-jx-reland-last-successful-prebuild.4
(with .werft/ from main)

@jankeromnes jankeromnes force-pushed the jx/reland-last-successful-prebuild branch from 09f9968 to fe48f9e Compare October 20, 2022 13:58
@jankeromnes jankeromnes changed the title Remerge "Use Last Successful Prebuild" Re-add "Use Last Successful Prebuild" Oct 20, 2022
@jankeromnes jankeromnes marked this pull request as ready for review October 20, 2022 14:30
@jankeromnes jankeromnes requested a review from a team October 20, 2022 14:30
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 20, 2022
@roboquat roboquat merged commit 7deb45d into main Oct 21, 2022
@roboquat roboquat deleted the jx/reland-last-successful-prebuild branch October 21, 2022 09:33
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants