Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: add db migration job to fluent bit logger #14051

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 20, 2022

Description

Add DB migration job to FluentBit ephemeral log collector

How to test

Install via KOTS, create a support bundle and search for migrations-xxx.migrations in the fluent bit logs

Release Notes

[kots]: add db migration job to fluent bit logger

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Oct 20, 2022

/hold this PR requires @gitpod-io/engineering-webapp approval to ensure that no sensitive data can be exposed via this logger

See attached bundle supportbundle-2022-10-20T15_42_36.tar.gz

@mrsimonemms mrsimonemms requested a review from a team October 20, 2022 15:53
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 20, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review October 20, 2022 15:53
@mrsimonemms mrsimonemms requested a review from a team October 20, 2022 15:53
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving that no sensitive data can be exposed via this logger ✔️

@mrsimonemms
Copy link
Contributor Author

/unhold thanks @geropl, much appreciated

@@ -74,6 +74,13 @@ spec:
Path /gitpod/log-collector
Format plain

[OUTPUT]
Name file
Match migrations*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly are we matching here? The pod name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - the file is in the format migrations-<id.<container-name>, so will pick up both db-waiter and migrations for the container name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the info!

@mrsimonemms
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 49d5143 into main Oct 21, 2022
@roboquat roboquat deleted the sje/kots-db-migration-logger branch October 21, 2022 07:05
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note size/XS team: SID team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants