Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewctl SA, rebuild and update docker image #14095

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

vulkoingim
Copy link
Contributor

Description

Fix an issue with passing a variable + trigger rebuild of the image so it's available in werft.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-preview with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@vulkoingim vulkoingim changed the title Fix previewctl SA and rebuild Fix previewctl SA, rebuild and update docker image Oct 21, 2022
@vulkoingim vulkoingim force-pushed the aa/previewctl-fix-rebuild branch from fbdffb0 to f5ac8d5 Compare October 21, 2022 17:30
@roboquat roboquat added size/M and removed size/S labels Oct 21, 2022
@vulkoingim vulkoingim force-pushed the aa/previewctl-fix-rebuild branch 2 times, most recently from 4e6289f to ff382bf Compare October 21, 2022 17:32
@vulkoingim vulkoingim marked this pull request as ready for review October 21, 2022 17:32
@vulkoingim vulkoingim requested review from a team October 21, 2022 17:32
@github-actions github-actions bot added team: SID team: devx team: IDE team: workspace Issue belongs to the Workspace team labels Oct 21, 2022
@vulkoingim vulkoingim force-pushed the aa/previewctl-fix-rebuild branch 2 times, most recently from 8d919ae to 645bf06 Compare October 24, 2022 08:19
@vulkoingim vulkoingim force-pushed the aa/previewctl-fix-rebuild branch from 645bf06 to 2f8ddb4 Compare October 24, 2022 08:25
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹

@roboquat roboquat merged commit dbdecc3 into main Oct 24, 2022
@roboquat roboquat deleted the aa/previewctl-fix-rebuild branch October 24, 2022 09:18
@roboquat roboquat added the deployed: IDE IDE change is running in production label Oct 24, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: SID team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants