Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix previewctl get-name and update image #14144

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix previewctl get-name and update image #14144

merged 1 commit into from
Oct 25, 2022

Conversation

vulkoingim
Copy link
Contributor

Description

Fix previewctl get-name

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C032A46PWR0/p1666639857490139

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@vulkoingim vulkoingim requested a review from a team October 25, 2022 07:03
@vulkoingim vulkoingim changed the title Fix previewctl get-name Fix previewctl get-name and update image Oct 25, 2022
@vulkoingim vulkoingim force-pushed the aa/fix-previewctl-get-name branch from f8ef5b7 to 9c16c4c Compare October 25, 2022 07:17
@vulkoingim vulkoingim requested review from a team October 25, 2022 07:17
@roboquat roboquat added size/M and removed size/S labels Oct 25, 2022
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@github-actions github-actions bot added team: SID team: devx team: IDE team: workspace Issue belongs to the Workspace team labels Oct 25, 2022
@roboquat roboquat merged commit 3393f87 into main Oct 25, 2022
@roboquat roboquat deleted the aa/fix-previewctl-get-name branch October 25, 2022 08:47
@mads-hartmann mads-hartmann mentioned this pull request Oct 25, 2022
Closed
@roboquat roboquat added the deployed: IDE IDE change is running in production label Oct 26, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liam-j-bennett liam-j-bennett liam-j-bennett approved these changes

@WVerlaek WVerlaek WVerlaek approved these changes

@felladrin felladrin felladrin approved these changes

@meysholdt meysholdt meysholdt approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: SID team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vulkoingim @meysholdt @felladrin @WVerlaek @liam-j-bennett @roboquat