Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing datasource variable #14207

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

ArthurSens
Copy link
Contributor

Description

#14168 introduced a dashboard focused on the health of our observability stack and it was created manually in Grafana. When backporting the JSON we missed to create a datasource variable, and now we're getting errors opening the dashboard

image

This PR just created the variable, so the dashboard loads successfully.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

One question. Happy with this going out as-is, but I'm keen to understand why if the answer is "no"

@roboquat roboquat merged commit ebc01f0 into main Oct 28, 2022
@roboquat roboquat deleted the as/fix-observability-dashboard branch October 28, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants