Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWS: Don't record the error log from getResourceInfo when the workspace has gone. #14218

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 27, 2022

Description

Don't record the error log from getResourceInfo when the workspace has gone to avoid noisy

Related Issue(s)

Fixes #12330

How to test

Open and close the workspace and check if there isn't noisy error log from the workspace pod.

Release Notes

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-12330.1 because the annotations in the pull request description changed
(with .werft/ from main)

@utam0k utam0k marked this pull request as ready for review October 27, 2022 06:27
@utam0k utam0k requested a review from a team October 27, 2022 06:27
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 27, 2022
@roboquat roboquat merged commit 2658f1f into main Oct 27, 2022
@roboquat roboquat deleted the to/12330 branch October 27, 2022 14:04
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@roboquat
Copy link
Contributor

@utam0k: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atduarte
Copy link
Contributor

@utam0k removed the release notes as from what I understand this doesn't directly benefit the end user of Gitpod. Let me know if my understanding is incorrect :)

@utam0k
Copy link
Contributor Author

utam0k commented Nov 28, 2022

@utam0k removed the release notes as from what I understand this doesn't directly benefit the end user of Gitpod. Let me know if my understanding is incorrect :)

Thanks. You are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production do-not-merge/release-note-label-needed size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] excessive logging for could not get resource information
5 participants