Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc-facade: squashes rare runc errors #14259

Merged
merged 1 commit into from
Oct 28, 2022
Merged

runc-facade: squashes rare runc errors #14259

merged 1 commit into from
Oct 28, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 28, 2022 •
edited by atduarte
Loading

Description

Related Issue(s)

Fixes #12365

How to test

Open a workspace and run docker-compose following README
https://utam0k-run30561c5246.preview.gitpod-dev.com/#https://github.com/spearki/gitpod-runc-issue-repro

$ ./generate.sh 20 > docker-compose.yml
$ docker compose up -d --force-recreate

Release Notes

Fix errors associated with running docker-compose with lots of containers

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@utam0k utam0k requested a review from a team October 28, 2022 13:52
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-utam0k-runc-facade-squashes-rare-12365.9 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 28, 2022
@roboquat roboquat merged commit 3660ed5 into main Oct 28, 2022
@roboquat roboquat deleted the utam0k/runc-facade-squashes-rare-12365 branch October 28, 2022 15:58
jenting
jenting reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why there are two different maximum retry counts (3 and 2). Can you explain why?

@utam0k
Copy link
Contributor Author

utam0k commented Oct 31, 2022

I have no idea why there are two different maximum retry counts (3 and 2). Can you explain why?

Ops, I mistake. Good catch

@utam0k utam0k mentioned this pull request Oct 31, 2022
Merged
4 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting left review comments

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runc-facade squashes rare runc errors
4 participants
@utam0k @sagor999 @jenting @roboquat