[kots]: set emptyDir and allow timeout configuration #14500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-fixes
branch
from
9fe55f1 to
7849013
Compare
|
/hold for @adrienthebo's input |
mrsimonemms
changed the title
|
/werft run with-sh-preview cluster=gke 👍 started the job as gitpod-build-sje-installer-fixes.2 |
adrienthebo
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
I'm having a hell of a time getting the CI pipelines to spin up a healthy environment with this change; I'm approving this to unblock the release but would like to test it before merging.
/hold for my review today, go ahead and merge in the AM in EMEA timezones otherwise.
|
/unhold I haven't verified this as closely as I want but the CI pipelines and I are not getting along. Let's merge this and cut 2022.10.2. |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
emptyDirto the installer job to store the/tmpdirectory. This is to add some ephemeral storage to reduce the probability of the installer pod being evicted, which has been reported by some users.Also adds an installer timeout option. This does not override the
1htimeout if thehttps-certificatessecret doesn't exist. The timeouts are added as set options - this avoids us having to have an extra preflight check which would add complexities/time.Related Issue(s)
Fixes #
How to test
Install via KOTS.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide