Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] don't swallow supervisor exit error #14650

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Nov 14, 2022

Description

[supervisor] don't swallow supervisor exit error

Related Issue(s)

Fixes #14293

How to test

Open https://github.com/mustard-mh/test/tree/hw/test-alpine in preview environment, it should failed with a message

image

Release Notes

[supervisor] don't swallow supervisor exit error

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@mustard-mh mustard-mh requested a review from a team November 14, 2022 06:01
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-no-error-14293.4 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-no-error-14293.5 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit 03aae67 into main Nov 14, 2022
@roboquat roboquat deleted the hw/no-error-14293 branch November 14, 2022 09:26
@felladrin
Copy link
Contributor

Tested and it worked as described.

Production Env Preview Env
image image

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error shown when workspace fails to start due to supervisor error
3 participants