[common-go] Move base database connection & types to common-go #14688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
force-pushed
the
mp/common-go-db
branch
from
ffad110 to
7eadc0c
Compare
easyCZ
force-pushed
the
mp/common-go-db
branch
from
7eadc0c to
1eea42d
Compare
|
/werft run 👍 started the job as gitpod-build-mp-common-go-db.3 |
liam-j-bennett
approved these changes
Nov 15, 2022
Furisto
approved these changes
Nov 15, 2022
andrew-farries
approved these changes
Nov 16, 2022
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves connection creation and basic DB types into
common-go. This originally lived in theusagecomponent, but with work on #14280, thepublic-api-serverwill interact with the DB also. Hence, we want to re-use our code between the two components andcommon-goseems to be the appropriate place.All changes in this PR are either:
Related Issue(s)
Fixes #
How to test
CI builds
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh