Skip to content

[public-api] Add Tokens RPC stubs #14722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged

[public-api] Add Tokens RPC stubs #14722

merged 1 commit into from
Nov 16, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 15, 2022

Description

Basic stubs for Tokens Service. Does the following:

  • Basic argument validation
  • Fetches the user, and ensures the user is allowed to access the feature
  • If allowed, returns Unimplemented.
  • If not, returns PermissionDenied

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold for dependency on #14713

@easyCZ easyCZ requested a review from a team November 15, 2022 22:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 15, 2022
Base automatically changed from mp/papi-tokens-get-token-stub to main November 16, 2022 08:56
@roboquat roboquat added size/XL and removed size/L labels Nov 16, 2022
@easyCZ easyCZ force-pushed the mp/papi-tokens-stubs branch from 81bc1b4 to 1ffb753 Compare November 16, 2022 09:00
@roboquat roboquat added size/L and removed size/XL labels Nov 16, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Nov 16, 2022

/werft run

👍 started the job as gitpod-build-mp-papi-tokens-stubs.2
(with .werft/ from main)

@easyCZ
Copy link
Member Author

easyCZ commented Nov 16, 2022

/werft run

👍 started the job as gitpod-build-mp-papi-tokens-stubs.3
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/papi-tokens-stubs branch from 1ffb753 to 5f165d8 Compare November 16, 2022 09:17
@easyCZ
Copy link
Member Author

easyCZ commented Nov 16, 2022

/unhold

@roboquat roboquat merged commit 3a9e9bf into main Nov 16, 2022
@roboquat roboquat deleted the mp/papi-tokens-stubs branch November 16, 2022 09:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants