[codehelper] replace product.json only #14821
Conversation
|
started the job as gitpod-build-hw-code-prod.1 because the annotations in the pull request description changed |
Tested with search, vote, marketplace. Are any other test cases to do? cc @akosyakov |
|
Will deploy after #14825 merge |
| b = bytes.ReplaceAll(b, []byte("{{extensionsGalleryItemUrl}}"), []byte("https://open-vsx.org/vscode/item")) | ||
| b = bytes.ReplaceAll(b, []byte("{{trustedDomain}}"), []byte("https://open-vsx.org")) |
There was a problem hiding this comment.
@mustard-mh I have a dumb question, why this got added 😅? I see they are added in dockerfile and then replaced here and in blobserve and they are just harcoded constant values 🤔
There was a problem hiding this comment.
I can't remember, maybe just a dumb action I did. 😅
There was a problem hiding this comment.
@akosyakov @iQQBot do you remember?
There was a problem hiding this comment.
I remembered what happened, https://open-vsx.org ({{trustedDomain}}) is too normal to replace in startup.sh, so I need to replace it to something more special, in case it is replaced by our openvsx-proxy in startup.sh.
Looks like we still need it?
There was a problem hiding this comment.
But the final value is harcoded here and in blobserve, where is openvsx-proxy updating this variable?
There was a problem hiding this comment.
It will replace them
gitpod/components/ide/code/codehelper/main.go
Line 279 in 6469258
And installer will replace https://open-vsx.org again
There was a problem hiding this comment.
yeah proxy url is fine, that needs to be replaced and that's why the first grep was needed.
I'm referring to {{extensionsGalleryItemUrl}}, {{trustedDomain}} they are replaced with constant values, the same values that are already in product.json in gp-code/main branch, it doesn't change like VSX_REGISTRY_URL that changes for each SH installation.
So just remove them then?
There was a problem hiding this comment.
The constant value are https://open-vsx.org and https://open-vsx.org/vscode/item they all contains open-vsx.org which will be replaced in installer and codehelper (startup.sh).
But we don't want them to be changed.
- In
codehelper, we can use sjson to Set value with json path we want - In
installer, it's just global replacement
So we still need them because of installer
There was a problem hiding this comment.
Ah I get it now 💡 , but then can we make the search more specific (with a regex maybe) so it doesn't replace the other values, right now it's not obvious at all
roboquat
added
deployed: IDE
Description
Replace
product.jsononly for browser code frontend to save duration of ide readySee also internal chat
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh