[public-api] Create token UI #14899
Merged
[public-api] Create token UI #14899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-jp-public-api-create-ui.1 because the annotations in the pull request description changed |
easyCZ
reviewed
Nov 24, 2022
|
This is awesome! Attaching screenshots just for completness: |
|
/hold for scopes change |
easyCZ
approved these changes
Nov 24, 2022
|
|
I've applied the suggested fix so we can land this. It remains behind a feature flag so future iterations to fix up are easy to do. Will unhold once the build passes. |
mustard-mh
force-pushed
the
jp/public-api-create-ui
branch
from
0fba79b to
0216592
Compare
|
Rebased to main, going to do some 🧹 /hold |
mustard-mh
force-pushed
the
jp/public-api-create-ui
branch
from
0216592 to
f64875a
Compare
Co-authored-by: Pudong <tianshi8650@gmail.com> Co-authored-by: Huiwen <mhqnwt@gmail.com> Co-authored-by: Milan Pavlik <pavlik.mil@gmail.com>
mustard-mh
force-pushed
the
jp/public-api-create-ui
branch
from
f64875a to
d0539a6
Compare
|
/werft run |
|
/werft run recreate-preview=true 👍 started the job as gitpod-build-jp-public-api-create-ui.8 |
roboquat
added
deployed: webapp
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fixes #14615
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh