Skip to content

[pat] List view with tokens #14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[pat] List view with tokens #14934

merged 1 commit into from
Nov 24, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Nov 24, 2022

Description

Second part to the list tokens view. This shows the list with token (without edit/regenerate/delete functions).

Screenshot 2022-11-24 at 20 15 48

Related Issue(s)

Fixes #14860

How to test

Preview env.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-list-tokens-view-3.2 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/L and removed size/M labels Nov 24, 2022
@laushinka laushinka force-pushed the lau/list-tokens-view-3 branch from ce88239 to 2c5f850 Compare November 24, 2022 19:13
@laushinka laushinka changed the title [pat] Try again seriously [pat] List view with tokens Nov 24, 2022
@laushinka laushinka force-pushed the lau/list-tokens-view-3 branch from 2c5f850 to 8e22bd1 Compare November 24, 2022 19:18
@laushinka laushinka marked this pull request as ready for review November 24, 2022 19:22
@laushinka laushinka requested a review from a team November 24, 2022 19:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 24, 2022
@easyCZ
Copy link
Member

easyCZ commented Nov 24, 2022

Screenshot 2022-11-24 at 20 27 03

Works nicely. UI will need some polish but we can do a UX pass subsequently. Nice work Laurie.

@roboquat roboquat merged commit b45617a into main Nov 24, 2022
@roboquat roboquat deleted the lau/list-tokens-view-3 branch November 24, 2022 19:29
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement List tokens UI
3 participants