[UBP] Disable subscriptions to old plans after UBP has been enabled #15092

jankeromnes · 2022-12-01T09:06:13Z

Description

Once UBP has been enabled for a user:

Disable individual Plan purchases/upgrades (/plans)
Disable old-style Team plan purchases/upgrades (/teams)
Disable new-style Team plan purchases/upgrades (Team Billing) -- upgrade UI gets entirely removed with UBP

Related Issue(s)

Fixes #14940

How to test

Upgrade to a paid Chargebee plan in https://jx-disable-chargebee.preview.gitpod-dev.com/plans
Buy a legacy Team Plan in https://jx-disable-chargebee.preview.gitpod-dev.com/teams
Once it's active, assign yourself one seat of this Team Plan
Now, create a team called "Gitpod [Something]" to unlock usage-based
If you now go to https://jx-disable-chargebee.preview.gitpod-dev.com/plans, you can no longer upgrade to any Chargebee paid plan -- you can only cancel by going into billing ⏩
If you go to https://jx-disable-chargebee.preview.gitpod-dev.com/teams, you can no longer create a new legacy Team Plan -- you can only cancel by going into billing ⏩

Release Notes

Disable upgrades of fixed-price monthly plans for individuals and teams who have pay-as-you-go enabled

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2022-12-01T09:06:21Z

started the job as gitpod-build-jx-disable-chargebee.1 because the annotations in the pull request description changed
(with .werft/ from main)

jankeromnes · 2022-12-02T09:40:00Z

Working well! 🎉

	/plans	/teams
BEFORE UBP	Can upgrade to individual plans	Can create and manage legacy team plans
AFTER UBP	Can no longer upgrade to Chargebee plans	Can no longer create legacy team plans

But, importantly, by visiting the old /plans or /teams URLs while on UBP and clicking on billing, you can still view/download your old Chargebee invoices 💡:

jankeromnes · 2022-12-02T09:42:12Z

Hint for reviewers: Reviewing while ignoring indentation changes is easier -- https://github.com/gitpod-io/gitpod/pull/15092/files?w=1

svenefftinge · 2022-12-02T09:57:56Z

After UBP GA do we actually want to allow any kind of plan changes other than cancellation?
We might just allow cancelling

jankeromnes · 2022-12-02T09:59:17Z

We might just allow cancelling

This PR disables all individual Plan actions when you're on UBP (i.e. Downgrade, Upgrade). You can still cancel via the Billing interface as usual. I don't think the Billing interface allows any other change than cancel.

EDIT: Ah, I guess you're asking whether we could do this (disable all plan changes) earlier, i.e. when the UBP flag is turned on, and not wait for when you've successfully cancelled all Chargebee plans? That would also make sense to me. 👍

EDIT 2: Done, let's try that.

jankeromnes · 2022-12-02T11:16:24Z

Hmm, my new change doesn't do exactly what I expected. Back to draft.

jankeromnes · 2022-12-02T14:56:23Z

Alright -- Chargebee upgrades in /plans and /teams are now disabled as soon as the usage-based billing flag is turned on. 👍

To test:

Go to /plans, upgrade to Chargebee
Go to /teams, buy a new team plan, assign yourself one seat
Create a team called "Gitpod [Something]" to enable usage-based flag
Now, /plans won't allow you to upgrade to new Chargebee plans (you can only click on billing and cancel)
Similarly, /teams won't allow you to buy new team plans or new seats (you can only cancel)

As requested in the issue, I've also added a blue infobox at the top of both pages when usage-based is enabled:

/plans	/teams

jldec · 2022-12-02T16:51:15Z

I tried to downgrade to free after upgrading the UBP while on a personal paid plan.
This seems to be disabled now and ~~the billing link at the top is missing as well~~ (it appeared later, must be a delay)
Downgrading to free == cancelling for individual plans, so we should preserve the ability to downgrade to free

Before (hovering over downgrade to free)

With UBP (hovering over downgrade to free)

jankeromnes · 2022-12-05T08:37:27Z

I tried to downgrade to free after upgrading the UBP while on a personal paid plan.
This seems to be disabled now and ~~the billing link at the top is missing as well~~ (it appeared later, must be a delay)
Downgrading to free == cancelling for individual plans, so we should preserve the ability to downgrade to free

Many thanks for the feedback @jldec!

The billing link part had me quite worried (should not happen and would break the cancellation UX), but if it came back I agree that it might be some delay or React state bug. In any case, a simple page reload should fix this.

Also, I agree that the Free card action should not get disabled, since downgrading to free is similar to cancelling from 'billing'. Will adjust this.

EDIT: Done ✅

jldec · 2022-12-05T10:41:30Z

@jankeromnes, when I first opened the team plans page, https://jx-disable-chargebee.preview.gitpod-dev.com/teams in the preview env, I got the dialog to create the new plan, and did not see the blue UBP enabled banner.

Refreshing the page, then disabled the green button, and showed the banner

The page now appears to be stuck on "payment in progress". I believe this is due my script blocker preventing the initial Chargebee interaction to create the 2nd plan (it flashed briefly but did not show any error). Normal browsers would have succeeded, and I expect the "payment in progress" message to time out eventually.

jankeromnes · 2022-12-05T10:56:16Z

@jankeromnes, when I first opened the team plans page, https://jx-disable-chargebee.preview.gitpod-dev.com/teams in the preview env, I got the dialog to create the new plan, and did not see the blue UBP enabled banner.

Refreshing the page, then disabled the green button, and showed the banner

Thanks! Then I guess this PR behaves mostly as expected.

The fact that a refresh is needed is likely due to a bug in how the dashboard-side feature flags are implemented (they don't seem to be using a "React dispatch", and they don't seem to be eagerly updated in App.tsx or Menu.tsx). In any case, this problem is out-of-scope for this PR. I guess the most important thing is that, once you have UBP enabled, eventually it's no longer possible to upgrade to new Chargebee plans. This seems to be the case.

and I expect the "payment in progress" message to time out eventually.

It should automatically time out in every browser after a few minutes. If not, that's a but in the Teams page (which is also out of scope here).

svenefftinge · 2022-12-05T13:18:41Z

Your account has been enabled for usage-based billing

We should say that the current plan is deprecated and will be cancelled by End of March 2023.
Also, talking about the benefits of the new pricing plans (workspace classes and flexible timeouts) would be good before pointing to "how to switch".

The disabled cards are still showing a hover effect that suggests they are clickable. Maybe we should not show those cards at all? Just have a big 'Cancel' button.

jankeromnes · 2022-12-05T17:12:41Z

Back to Draft to implement the reword / redesign suggestion.

geropl · 2022-12-05T17:40:21Z

@jankeromnes Note that we already limit API interactions based on BillingMode. I did not read the whole context on this PR, but wanted to mentioning it because it make sense to keep that in sync with what we do in the UI.

…s enabled

… is enabled

jankeromnes · 2022-12-05T18:24:21Z

We should say that the current plan is deprecated and will be cancelled by End of March 2023.
Also, talking about the benefits of the new pricing plans (workspace classes and flexible timeouts) would be good before pointing to "how to switch".

@svenefftinge Okay, here is my counter-proposal:

Plans	Teams

The disabled cards are still showing a hover effect that suggests they are clickable. Maybe we should not show those cards at all? Just have a big 'Cancel' button.

I've removed the hover effect by adding the pointer-events-none class to disabled Plan cards (this removes all hover and click effects, even if you have listeners).

On the other hand, while I like your more radical proposal of only having a big 'Cancel' button (or, even better, having a new UI that takes users through a single flow from Chargebee cancellation to Stripe re-upgrade), I don't think it's trivial to get the UI right in a short time. It might also be confusing to significantly change the Plans page layout, making it unrecognizable and confusing.

Thus, I'd argue that we merge this PR as is now, and figure out whether a better disabled UI is needed or desirable after GA. 😇

gtsiolis

Left a comment on the copy used in the alert. 🚨

gtsiolis · 2022-12-05T19:11:45Z

components/dashboard/src/settings/Plans.tsx

+                    <Alert type="message" className="mb-4">
+                        Your account has been enabled for usage-based billing. Discover faster workspace classes and
+                        only pay for what you actually use.{" "}
+                        <a className="gp-link" href="https://www.gitpod.io/docs/configure/billing/usage-based-billing">
+                            Learn more
+                        </a>
+                        <br />
+                        <br />
+                        The old monthly plans are deprecated and will be cancelled by End of March 2023.
+                    </Alert>


Hey @jankeromnes! Some thoughts on the copy used here:

Too verbose, or uses unnecessary empty space.

Focus on the personal account, not team plans or team billing.

Sounds like the user has been part of a closed beta list and not accessing a GA feature on Gitpod.io.

Voice and tone is not direct, using terms like discover.

Lack of clear action. Do we want to provide an action for users or nudge to perform an action?

What do you think of the following copy?

BEFORE AFTER

Let's not call our pricing as a whole "pay-as-you-go". the pay as you go bit is only the mode where you pay later. We have a free plan and a personal plan with a certain amount of credits that is not pay-as-you-go. We'll likely have other ways to prepurchase credits in the future.
"Usage-based" is ok but I'd prefer to generally just talk about (new) pricing.

jldec · 2022-12-06T01:33:29Z

@jankeromnes - The notification copy to use is:

To access large workspaces and pay-as-you-go, first cancel your existing plan.
Existing plans will keep working until the end of March, 2023.

Thanks @gtsiolis and @svenefftinge for your inputs.
🙏

Details behind this wording are in this RFC (internal)

svenefftinge

Looks good. I know there is an ongoing discussion about the exact wording, but the current state is good already and we can do the adjustments in even smaller PRs later.

roboquat added do-not-merge/work-in-progress release-note labels Dec 1, 2022

roboquat added the size/L label Dec 1, 2022

jankeromnes force-pushed the jx/disable-chargebee branch 3 times, most recently from 5c2609a to 3f02783 Compare December 1, 2022 17:13

jankeromnes marked this pull request as ready for review December 2, 2022 09:40

jankeromnes requested a review from a team December 2, 2022 09:40

roboquat removed the do-not-merge/work-in-progress label Dec 2, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 2, 2022

jankeromnes force-pushed the jx/disable-chargebee branch from 3f02783 to 25c8bc8 Compare December 2, 2022 10:26

jankeromnes marked this pull request as draft December 2, 2022 11:16

roboquat added the do-not-merge/work-in-progress label Dec 2, 2022

jankeromnes force-pushed the jx/disable-chargebee branch 4 times, most recently from a746f04 to a6793f7 Compare December 2, 2022 14:52

jankeromnes marked this pull request as ready for review December 2, 2022 14:56

roboquat removed the do-not-merge/work-in-progress label Dec 2, 2022

jankeromnes force-pushed the jx/disable-chargebee branch from a6793f7 to 75f90ad Compare December 5, 2022 09:12

jankeromnes marked this pull request as draft December 5, 2022 17:12

roboquat added the do-not-merge/work-in-progress label Dec 5, 2022

jankeromnes added 2 commits December 5, 2022 18:17

[dashboard] Prevent upgrading to Chargebee once Usage-Based Pricing i…

b7c2506

…s enabled

[dashboard] Add blue infobox to Plans and Teams page when usage-based…

ea611f2

… is enabled

jankeromnes force-pushed the jx/disable-chargebee branch from 75f90ad to ea611f2 Compare December 5, 2022 18:17

jankeromnes marked this pull request as ready for review December 5, 2022 18:24

roboquat removed the do-not-merge/work-in-progress label Dec 5, 2022

gtsiolis reviewed Dec 5, 2022

View reviewed changes

svenefftinge approved these changes Dec 6, 2022

View reviewed changes

roboquat merged commit c98f5f3 into main Dec 6, 2022

roboquat deleted the jx/disable-chargebee branch December 6, 2022 07:10

jankeromnes mentioned this pull request Dec 6, 2022

Adjust wording pricing change notification #15173

Closed

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 6, 2022

jankeromnes mentioned this pull request Dec 6, 2022

[dashboard] Adjust Chargebee plan end-of-life notification text #15181

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UBP] Disable subscriptions to old plans after UBP has been enabled #15092

[UBP] Disable subscriptions to old plans after UBP has been enabled #15092

jankeromnes commented Dec 1, 2022 •

edited by atduarte

Loading

werft-gitpod-dev-com bot commented Dec 1, 2022

jankeromnes commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 2, 2022

svenefftinge commented Dec 2, 2022

jankeromnes commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 2, 2022

jankeromnes commented Dec 2, 2022 •

edited

Loading

jldec commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022 •

edited

Loading

jldec commented Dec 5, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022 •

edited

Loading

svenefftinge commented Dec 5, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022

geropl commented Dec 5, 2022

jankeromnes commented Dec 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis Dec 5, 2022 •

edited

Loading

svenefftinge Dec 6, 2022

gtsiolis Dec 6, 2022

jldec commented Dec 6, 2022 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge left a comment

[UBP] Disable subscriptions to old plans after UBP has been enabled #15092

[UBP] Disable subscriptions to old plans after UBP has been enabled #15092

Conversation

jankeromnes commented Dec 1, 2022 • edited by atduarte Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

Werft options:

werft-gitpod-dev-com bot commented Dec 1, 2022

jankeromnes commented Dec 2, 2022 • edited Loading

jankeromnes commented Dec 2, 2022

svenefftinge commented Dec 2, 2022

jankeromnes commented Dec 2, 2022 • edited Loading

jankeromnes commented Dec 2, 2022

jankeromnes commented Dec 2, 2022 • edited Loading

jldec commented Dec 2, 2022 • edited Loading

jankeromnes commented Dec 5, 2022 • edited Loading

jldec commented Dec 5, 2022 • edited Loading

jankeromnes commented Dec 5, 2022 • edited Loading

svenefftinge commented Dec 5, 2022 • edited Loading

jankeromnes commented Dec 5, 2022

geropl commented Dec 5, 2022

jankeromnes commented Dec 5, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

gtsiolis Dec 5, 2022 • edited Loading

Choose a reason for hiding this comment

svenefftinge Dec 6, 2022

Choose a reason for hiding this comment

gtsiolis Dec 6, 2022

Choose a reason for hiding this comment

jldec commented Dec 6, 2022 • edited by werft-gitpod-dev-com bot Loading

svenefftinge left a comment

Choose a reason for hiding this comment

jankeromnes commented Dec 1, 2022 •

edited by atduarte

Loading

jankeromnes commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 2, 2022 •

edited

Loading

jldec commented Dec 2, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022 •

edited

Loading

jldec commented Dec 5, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022 •

edited

Loading

svenefftinge commented Dec 5, 2022 •

edited

Loading

jankeromnes commented Dec 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis Dec 5, 2022 •

edited

Loading

jldec commented Dec 6, 2022 •

edited by werft-gitpod-dev-com bot

Loading