Skip to content

[dashboard] make sure all team route under /t #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

mustard-mh
Copy link
Contributor

Description

See also #15002 (comment)

Related Issue(s)

Fixes #15002 (comment)

How to test

  • Open preview env
  • Go to settings -> Personal Access Token, check if navigation elements are correct

❓ What should we test to prevent regression of /t/<xxx> and <xxx>

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mustard-mh-design-improvements-15002.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Dec 5, 2022

❓ What should we test to prevent regression of /t/<xxx> and <xxx>

@easyCZ @laushinka @gtsiolis do you have any cases that need to be covered about team routers?

@laushinka
Copy link
Contributor

do you have any cases that need to be covered about team routers?

  • /projects
    • /branches
    • /prebuilds
    • /settings
  • /members
  • /usage
  • /settings

How about we write unit tests for these? Also happy to pair if you'd like.

@mustard-mh mustard-mh force-pushed the mustard-mh/design-improvements-15002 branch from d8c43c7 to b2b2fa0 Compare December 6, 2022 15:49
@roboquat roboquat added size/S and removed size/XS labels Dec 6, 2022
@mustard-mh
Copy link
Contributor Author

Changes make sure the navigation buttons only appear when the route is under /t or /projects. Not add test cases yet. We can do it in follow-up PR. cc @laushinka

Personal Projects

1. Personal projects image
2. Personal projects with prebuild image

Team

1. Team hello with member image
2. Team hello with project prebuild image
3. Team hello with project prebuild details image

Personal Access Token

1. PAT Create image
2. PAT Edit image

@jeanp413 jeanp413 marked this pull request as ready for review December 6, 2022 17:19
@jeanp413 jeanp413 requested a review from a team December 6, 2022 17:19
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 6, 2022
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM, @mustard-mh! 🔮

@laushinka
Copy link
Contributor

Not add test cases yet. We can do it in follow-up PR.

Sure. LGTM - thanks for fixing this!

@roboquat roboquat merged commit 98bec46 into main Dec 6, 2022
@roboquat roboquat deleted the mustard-mh/design-improvements-15002 branch December 6, 2022 17:30
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design improvements for the personal access tokens page and flow
4 participants