-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] make sure all team route under /t
#15161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-mustard-mh-design-improvements-15002.1 because the annotations in the pull request description changed |
@easyCZ @laushinka @gtsiolis do you have any cases that need to be covered about team routers? |
How about we write unit tests for these? Also happy to pair if you'd like. |
d8c43c7
to
b2b2fa0
Compare
Changes make sure the navigation buttons only appear when the route is under Personal Projects Team Personal Access Token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX LGTM, @mustard-mh! 🔮
Sure. LGTM - thanks for fixing this! |
Description
See also #15002 (comment)
Related Issue(s)
Fixes #15002 (comment)
How to test
❓ What should we test to prevent regression of
/t/<xxx>
and<xxx>
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh