Skip to content

Update beta label on access tokens #15221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Dec 7, 2022

Description

Follow up from #15201.

See also relevant discussion in #15201 (comment) and follow-up issue to improve the label component in #15218.

BEFORE AFTER
label-before label-after

How to test

  1. Go to /tokens
  2. Notice the label visual update

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team December 7, 2022 15:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 7, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-beta-label-on-access-tokens.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-beta-label-on-access-tokens.2 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 9, 2022

Holding to unblock merge queue.

/hold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 9, 2022

Thanks for taking a look, @easyCZ!

/unhold

@roboquat roboquat merged commit 2cb708f into main Dec 9, 2022
@roboquat roboquat deleted the gt/update-beta-label-on-access-tokens branch December 9, 2022 14:00
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants