-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Introduce new version designs #15397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,42 +176,40 @@ function renderIdeOption( | |
version: IDEOption["imageVersion"], | ||
onSelect: () => void, | ||
): JSX.Element { | ||
const label = option.type === "desktop" ? "" : option.type; | ||
const shouldShowOptionType = option.type !== "desktop" || option.title === "VS Code"; // Force show of "Desktop" in the list for VS Code Desktop | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. taking a note on hardcoding, let's go with it for now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, we could add something like |
||
const card = ( | ||
<SelectableCardSolid className="w-36 h-44" title={option.title} selected={selected} onClick={onSelect}> | ||
<div className="flex justify-center mt-3"> | ||
<img className="w-16 filter-grayscale self-center" src={option.logo} alt="logo" /> | ||
</div> | ||
<div | ||
className="mt-2 px-3 py-1 self-center" | ||
style={{ | ||
minHeight: "1.75rem", | ||
}} | ||
> | ||
{label ? ( | ||
<span | ||
className={`font-semibold text-sm ${ | ||
selected ? "text-gray-100 dark:text-gray-600" : "text-gray-600 dark:text-gray-500" | ||
} uppercase`} | ||
> | ||
{label} | ||
</span> | ||
) : ( | ||
<></> | ||
)} | ||
</div> | ||
|
||
{version ? ( | ||
<div | ||
className={`font-semibold text-xs ${ | ||
selected ? "text-gray-100 dark:text-gray-600" : "text-gray-600 dark:text-gray-500" | ||
} uppercase px-3 self-center`} | ||
<span | ||
filiptronicek marked this conversation as resolved.
Show resolved
Hide resolved
filiptronicek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
className={`font-normal font-mono text-xs ${ | ||
selected | ||
? "text-gray-100 dark:text-gray-600" | ||
: "text-gray-400 contrast-more:text-gray-600 dark:text-gray-500" | ||
} pl-1 self-start`} | ||
title="The IDE's current version on Gitpod" | ||
> | ||
{version} | ||
</div> | ||
</span> | ||
) : ( | ||
<span | ||
style={{ | ||
minHeight: "1rem", | ||
}} | ||
></span> | ||
)} | ||
<div className="flex justify-center mt-3 mb-2"> | ||
<img className="w-16 filter-grayscale self-center" src={option.logo} alt="logo" /> | ||
</div> | ||
{shouldShowOptionType ? ( | ||
<PillLabel type="warn" className="place-self-start py-0.5 my-2 flex"> | ||
<span className="text-xs capitalize">{option.type}</span> | ||
</PillLabel> | ||
) : ( | ||
<></> | ||
option.label && ( | ||
<PillLabel type="neutral" className="place-self-start py-0.5 my-2 flex"> | ||
<span className="text-xs normal-case font-medium">{option.label}</span> | ||
</PillLabel> | ||
) | ||
)} | ||
</SelectableCardSolid> | ||
); | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Going with the same subtle (neutral) label could be nice with the upcoming changes in #15389, see relevant designs in #15287 (comment). Cc @svenefftinge
Alternatively, using the info variant could be also a good way forward. But in any case, going with the neutral and improving the label designs (colors) (#15218) in the future sounds good.