Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] show detail message if supervisor failed #15602

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jan 6, 2023

Description

show detail message if supervisor failed

image

Related Issue(s)

Fixes #14293

How to test

  1. start a workspace using https://github.com/iQQBot/test.test/tree/pd/test-log this branch, it will fail and show detail log

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-sup-log.1 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 6, 2023

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pd-sup-log.3
(with .werft/ from main)

@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 6, 2023

/werft run

👍 started the job as gitpod-build-pd-sup-log.4
(with .werft/ from main)

@iQQBot iQQBot marked this pull request as ready for review January 6, 2023 17:11
@iQQBot iQQBot requested a review from a team January 6, 2023 17:11
@iQQBot
Copy link
Contributor Author

iQQBot commented Jan 6, 2023

/werft run

👍 started the job as gitpod-build-pd-sup-log.5
(with .werft/ from main)

@mustard-mh mustard-mh changed the title [suoervisor] show detail message if supervisor failed [supervisor] show detail message if supervisor failed Jan 10, 2023
@mustard-mh
Copy link
Contributor

mustard-mh commented Jan 11, 2023

/werft run

👍 started the job as gitpod-build-pd-sup-log.6
(with .werft/ from main)

@roboquat roboquat merged commit 223052f into main Jan 11, 2023
@roboquat roboquat deleted the pd/sup-log branch January 11, 2023 18:52
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jan 12, 2023
@kylos101
Copy link
Contributor

Thank you @iQQBot and @mustard-mh ! 💪

cc: @WVerlaek @atduarte for 👀 , fixes #14293, the test in this PR used an alpine based image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error shown when workspace fails to start due to supervisor error
4 participants