Se/update-team-api #15714
Closed
Se/update-team-api #15714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
requested review from
csweichel,
akosyakov and
easyCZ
as code owners
easyCZ
reviewed
Jan 12, 2023
| @@ -114,6 +118,68 @@ func (s *TeamService) ListTeams(ctx context.Context, req *connect.Request[v1.Lis | |||
| }), nil | |||
| } | |||
|
|
|||
| func (s *TeamService) UpdateTeam(ctx context.Context, req *connect.Request[v1.UpdateTeamRequest]) (*connect.Response[v1.UpdateTeamResponse], error) { | |||
There was a problem hiding this comment.
Unit tests, please. So far the Public API has nearly 100% coverage and I'd like to keep it that way.
svenefftinge
force-pushed
the
se/update-team-api
branch
from
d6df2b0 to
9068c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an API endpoint to update a team (only name changes are allowed atm).
FWIW: I believe we should rewrite all of the team calls and directly talk to the DB, so we can eventually get rid of the websocket-connection to server. I think a poor man implementation of checking what operations a user can do would be easy and ok until we can use FGA.
Related Issue(s)
See #5067
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh