-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dashboard] Suggest using gp rebuild
when image build fails
#15774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
b9a394d
to
e0ded0d
Compare
gp rebuild
when image build fails
@gtsiolis I would appreciate your touch here! Other approaches I've considered:
|
e0ded0d
to
a72474d
Compare
I think custom can be dropped, a user can also use it to validate any other base image, just workspace image? |
Looking at this now! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with similar approaches (see relevant discussion (internal)), our existing alert component flexibility, and similar components in the wild that could support what we want here.
UX LGTM and seems like a good skateboard! 🛹
Thanks for the ping[1], @andreafalzetti! 🏓
FWIW, I couldn't test this because I was getting the following error:
Request createWorkspace failed with message: 13 INTERNAL: cannot resolve workspace image: pulling from host eu.gcr.io failed with status code [manifests 81971a6456bed2bd0c75aa21ad46ba7932353c4f0227d22d09025deac0b573cb]: 429
Too Many Requests
Unknown Error: { "code": -32603 }
<span className="font-bold">Did you know?</span> You can use <code>gp rebuild</code> to | ||
validate and debug your custom workspace image before pushing · |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: We could trim some text here to make it easier to parse and read. Haven't checked if linting fails with the following code suggestions. 😅
<span className="font-bold">Did you know?</span> You can use <code>gp rebuild</code> to | |
validate and debug your custom workspace image before pushing · | |
💡 You can use the <code>gp rebuild</code> command to | |
validate the configuration and rebuild the workspace. |
We could also skip the validation part as this could be self-explanatory, making the message even easier to read and more specific where you can use the rebuild
command.
<span className="font-bold">Did you know?</span> You can use <code>gp rebuild</code> to | |
validate and debug your custom workspace image before pushing · | |
💡 You can use the <code>gp rebuild</code> command to | |
rebuild the workspace from the editor terminal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the inspiration! I've updated the message, check if you like it or have more suggestions 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks shippable, @andreafalzetti! Here are background thoughts on the copy suggestion above, but the current state looks good for this iteration, and we can update the copy later.
- The rebuild term was referring to the image build of the container image.
- The workspace term was trying to communicate this is about your workspace and nothing scary like images, containers, etc which may be strange to some users.
- The command term reference was trying to make it clear this is an actual command you have to type in a terminal or somewhere to run it.
- The debug term was removed to make it less scary to users.
- The editor term was used to clarify this action can happen inside an editor. Could be removed as this can happen in a terminal locally if you connect with SSH.
- The terminal term was used to make it clear you need to type this command in a terminal and it's not something you find on the editor UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtsiolis for context, we'll also enable users calling gp rebuild
from the UI (vscode only for now), see context, but it feels very hard compress all these info in a line. For now we can go with the "terminal" option and later once we create more generic docs on gitpod.io/docs, we can rephrase this and link there to be a generic "rebuild" feature
74107f1
to
35ff9e1
Compare
<span className="font-bold">Did you know?</span> You can use <code>gp rebuild</code> to | ||
validate and debug your custom workspace image before pushing · |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks shippable, @andreafalzetti! Here are background thoughts on the copy suggestion above, but the current state looks good for this iteration, and we can update the copy later.
- The rebuild term was referring to the image build of the container image.
- The workspace term was trying to communicate this is about your workspace and nothing scary like images, containers, etc which may be strange to some users.
- The command term reference was trying to make it clear this is an actual command you have to type in a terminal or somewhere to run it.
- The debug term was removed to make it less scary to users.
- The editor term was used to clarify this action can happen inside an editor. Could be removed as this can happen in a terminal locally if you connect with SSH.
- The terminal term was used to make it clear you need to type this command in a terminal and it's not something you find on the editor UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andreafalzetti! 🍕
Left one minor suggestion around the help link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the message should include something telling me where I can use gp rebuild
. George's proposal sounds much better to me:
💡 You can use the
gp rebuild
command to rebuild the workspace from the editor terminal.
/hold
Ups, it got merged even though I added the |
Description
We've recently introduced
gp rebuild
to help users debug their custom workspace image. In the future it will do more. We hope to reduce the number of image build failures caused by config changes that could have been caught in a workspace, before pushing.Related Issue(s)
Relates #7671
How to test
gp rebuild
underneath the logsRelease Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh