[Gitpod CLI] Auto-install Docker when it's not available in the system #15839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
force-pushed
the
ide/gp-rebuild-auto-install-docker
branch
from
d18e164 to
ac60947
Compare
This comment was marked as outdated.
This comment was marked as outdated.
felladrin
force-pushed
the
ide/gp-rebuild-auto-install-docker
branch
from
ac60947 to
b46d1a8
Compare
akosyakov
reviewed
Jan 18, 2023
felladrin
force-pushed
the
ide/gp-rebuild-auto-install-docker
branch
5 times, most recently
from
d91df0c to
cc4c8a8
Compare
|
ℹ️ It now checks if the user is running as root or if the user has at least access to "sudo" before running the docker install. We're not using the rootless-script anymore. |
felladrin
force-pushed
the
ide/gp-rebuild-auto-install-docker
branch
from
cc4c8a8 to
53d69e3
Compare
|
ℹ️ We're considering closing this PR in favor of another approach: to restart the workspace using the base Gitpod image, which already has docker installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auto-install Docker when it's not available in the system.
Related Issue(s)
gp rebuildimprovements #15740How to test
Open a workspace which uses an image (e.g. ubuntu / busybox) without Docker installed (e.g. https://github.com/gitpod-samples/template-elixir), and confirm if
gp rebuildworks.Release Notes
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh