[Dashboard] Deslugging #16070
[Dashboard] Deslugging #16070
Conversation
|
started the job as gitpod-build-se-deslugging.1 because the annotations in the pull request description changed |
svenefftinge
force-pushed
the
se/deslugging
branch
from
0df0646 to
0ead92c
Compare
| @@ -232,13 +228,13 @@ export default function Menu() { | |||
| ) { | |||
| teamSettingsList.push({ | |||
| title: "Usage", | |||
| link: `/t/${team.slug}/usage`, | |||
| link: `/org-usage`, | |||
There was a problem hiding this comment.
we can align usage and org-usage in follow-up steps, same for billing/org-billing
There was a problem hiding this comment.
Sounds good - the /org-usage path here felt weird to me since nothing else is prefixed by /org-. Do you mean it'll be easier to change after this PR to something like that?
There was a problem hiding this comment.
It's just fewer changes. the PR is already quite big.
| const entries: (ContextMenuEntry & { slug: string })[] = [ | ||
| ...(hasIndividualProjects | ||
| const entries: ContextMenuEntry[] = [ | ||
| ...(!user?.additionalData?.isMigratedToTeamOnlyAttribution |
There was a problem hiding this comment.
with this change I'm adding the previously deprecated "personal account" entry back in the drop-down menu unless you have been migrated (in preview env everyone is migrated, so you don't see this) If you want to test the behavior you need to change the config cat value and delete/recreate your user.
svenefftinge
force-pushed
the
se/deslugging
branch
from
0ead92c to
6dc433f
Compare
|
Something doesn't seem to persist my org selection between a refresh. For example:
Related - If you create a project under each team, and navigate to Team B, select a project so you're on something like the project's branches (or another project tab), and refresh, you end up w/ Team A select, and an empty project page. |
|
/werft run 👍 started the job as gitpod-build-se-deslugging.4 |
svenefftinge
force-pushed
the
se/deslugging
branch
from
6dc433f to
c97ba94
Compare
|
Thank you @selfcontained 🙏 I've fixed the reload issue and also addressed all of your feedback. |
svenefftinge
force-pushed
the
se/deslugging
branch
2 times, most recently
from
f8c7039 to
fbe8ac6
Compare
svenefftinge
force-pushed
the
se/deslugging
branch
from
fbe8ac6 to
e056477
Compare
roboquat
added
deployed: webapp
Description
This change removes the team slugs and instead relies on a search param that if provided on any URL will switch the currently active org. I've decided not only add a generic redirect for old URLs (
/t/*) under the assumption that those URLs are not (or super rarely) shared outside the app (I have no data 😇 )Attention: This is a follow up and includes the changes in #16050, you can either review all changes together or separated
Related Issue(s)
Fixes #16053
How to test
Check all navigation paths and verify they work as intended.
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh