Skip to content

[ws-manager-mk2] Workspace heartbeats and timeouts #16122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WVerlaek
Copy link
Member

Description

DRAFT - still work in progress.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Jan 31, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-ws-timeouts branch 2 times, most recently from e5b66ad to d893431 Compare January 31, 2023 16:13
@iQQBot iQQBot self-requested a review February 1, 2023 08:10
@roboquat roboquat added size/XXL and removed size/XL labels Feb 1, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-ws-timeouts branch 5 times, most recently from 7b8c876 to 3150e68 Compare February 2, 2023 12:54
Refactor to use in-memory ws activity map

Timeout controller

Delete workspace when timed out, fix duration string

Controller set max concurrency

Return last activity in DescribeWorkspace
@kylos101
Copy link
Contributor

kylos101 commented Feb 7, 2023

@WVerlaek can this PR be closed, because of #16209 and #16181?

cc: @Furisto

@WVerlaek
Copy link
Member Author

WVerlaek commented Feb 7, 2023

@kylos101 will close now, was keeping it open while splitting out the work to remember to check I didn't forget anything

@WVerlaek WVerlaek closed this Feb 7, 2023
@WVerlaek WVerlaek deleted the wv/mk2-ws-timeouts branch February 7, 2023 10:34
@kylos101
Copy link
Contributor

kylos101 commented Feb 7, 2023

@kylos101 will close now, was keeping it open while splitting out the work to remember to check I didn't forget anything

Good call, I appreciate your attention to detail! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants