[ws-manager-mk2] Extract ctrl utils to common-go #16226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: workspace
|
/werft run 👍 started the job as gitpod-build-wv-ctrl-utils.2 |
aledbf
approved these changes
Feb 6, 2023
WVerlaek
force-pushed
the
wv/mk2-mark-active
branch
from
463ee02 to
3863ce7
Compare
WVerlaek
force-pushed
the
wv/ctrl-utils
branch
from
a81ce66 to
9c41ff8
Compare
WVerlaek
force-pushed
the
wv/ctrl-utils
branch
from
9c41ff8 to
f7ae052
Compare
|
/unhold |
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup: use existing k8s utils from common-go, and extract some new common util functions in mk2 to common-go.
Stacked PR on #16181, adding hold.
Related Issue(s)
Relates to #11416
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh