Skip to content

[ws-manager-mk2] Fix and enable controller tests #16247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Feb 6, 2023

Description

  • Fix several panics in the mk2 controller test suite
  • Upgrade/migrate to ginkgo/v2
    • Fixes deprecation warnings on test runs
  • Enable tests on leeway build

Related Issue(s)

Relates to #11416

How to test

Run

cd components/ws-manager-mk2
go test ./...

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
  • /werft publish-to-npm

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Feb 6, 2023
@WVerlaek WVerlaek requested a review from a team February 6, 2023 16:18
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 6, 2023
@roboquat roboquat added size/L and removed size/M labels Feb 6, 2023
@WVerlaek
Copy link
Member Author

WVerlaek commented Feb 6, 2023

Had to update dependencies of a number of go modules that depend on ws-manager-api.

Also increased the timeout for envtest starting/stopping the k8s control plane from 20s to 1 minute, because I saw some timeouts when the workspace is under load

@roboquat roboquat merged commit 093338c into main Feb 8, 2023
@roboquat roboquat deleted the wv/fix-ctrl-tests branch February 8, 2023 15:47
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note-none size/L team: delivery-operations-experience team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants