Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] pass organizationId to create ws #16364

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[server] pass organizationId to create ws #16364

merged 1 commit into from
Feb 14, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Feb 13, 2023

Description

Adds organizationId to the create workspace options. Also removes dependencies on implicit org retrieval from some of the create Workspace logic.

Related Issue(s)

Part of #16362

How to test

Start workspaces and verify that the usage attribution is the same as it usually is.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-orgid-on-create.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

/hold for testing

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know when you've finished testing and I'll re-review.

components/server/src/user/user-service.ts Outdated Show resolved Hide resolved
components/server/src/workspace/workspace-starter.ts Outdated Show resolved Hide resolved
components/server/src/workspace/workspace-starter.ts Outdated Show resolved Hide resolved
@svenefftinge svenefftinge marked this pull request as draft February 13, 2023 09:16
@svenefftinge svenefftinge force-pushed the se/orgid-on-create branch 2 times, most recently from 97140d6 to c2dd771 Compare February 13, 2023 09:47
@svenefftinge svenefftinge marked this pull request as ready for review February 13, 2023 11:26
@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 0c0178b into main Feb 14, 2023
@roboquat roboquat deleted the se/orgid-on-create branch February 14, 2023 11:07
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants