Skip to content

[ws-manager-mk2] Add finalizer on workspace, handle ws deletion #16400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

WVerlaek
Copy link
Member

Description

  • Add finalizer on the Workspace resource as well - such that deleting the workspace resource directly (instead of the Pod) still gracefully stops the workspace.
  • Handle deleting the workspace resource, by propagating the deletion to the Pod, which then continuous deletion as normal.
  • Once the workspace transitions to a Stopped phase, remove the finalizer on the workspace and finish deletion.

Related Issue(s)

Part of #11416

How to test

  • Open a workspace
  • kubectl delete ws <name>
  • Observe the workspace gracefully shuts down with a backup, and eventually disappears from the cluster in kubectl get ws.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-wv-mk2-workspace-finalizer.1 because the annotations in the pull request description changed
(with .werft/ from main)

@WVerlaek
Copy link
Member Author

WVerlaek commented Feb 14, 2023

/werft run

👍 started the job as gitpod-build-wv-mk2-workspace-finalizer.2
(with .werft/ from main)

@WVerlaek
Copy link
Member Author

WVerlaek commented Feb 14, 2023

/werft run with-wsman-mk2 recreate-vm

👍 started the job as gitpod-build-wv-mk2-workspace-finalizer.3
(with .werft/ from main)

@WVerlaek
Copy link
Member Author

WVerlaek commented Feb 14, 2023

/werft run with-wsman-mk2 recreate-vm

👍 started the job as gitpod-build-wv-mk2-workspace-finalizer.4
(with .werft/ from main)

@WVerlaek WVerlaek marked this pull request as ready for review February 15, 2023 06:12
@WVerlaek WVerlaek requested a review from a team February 15, 2023 06:12
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 15, 2023
@roboquat roboquat merged commit 00229da into main Feb 15, 2023
@roboquat roboquat deleted the wv/mk2-workspace-finalizer branch February 15, 2023 10:27
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants