[ws-manager-mk2] Fix workspace URL not set in env #16407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
commented
Feb 15, 2023
| @@ -87,7 +87,7 @@ func main() { | |||
| Port: 9443, | |||
| HealthProbeBindAddress: cfg.Health.Addr, | |||
| LeaderElection: enableLeaderElection, | |||
| LeaderElectionID: "ws-manager-mk2.gitpod.io", | |||
| LeaderElectionID: "ws-manager-mk2-leader.gitpod.io", | |||
There was a problem hiding this comment.
this ID shows up as a ConfigMap, including leader makes it more obvious that the configmap is used for leader-election
Furisto
approved these changes
Feb 15, 2023
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes workspace creation using unset status fields, causing e.g. the workspace URL env var to be empty.
Instead, on creation of the workspace container, construct the URL and headless status directly.
Related Issue(s)
Relates to #11416
How to test
gp infoand see the workspace URL is not emptyRelease Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh