Skip to content

[gitpod-code] gp rebuild hints experiment #16514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[gitpod-code] gp rebuild hints experiment #16514

merged 1 commit into from
Feb 23, 2023

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 22, 2023

Description

This PR adds an experiment to improve discoverability of gp rebuild feature in VS Code interface:

  • via a notification on save of .gitpod.yml or Dockerfile
  • UI actions in code lenses, editor context and inline menus

gitpod-code commit on master

Related Issue(s)

Fixes #16299

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft analytics=segment
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-code-validate.1 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov
Copy link
Member Author

akosyakov commented Feb 23, 2023

/werft run

👍 started the job as gitpod-build-ak-code-validate.2
(with .werft/ from main)

@akosyakov
Copy link
Member Author

akosyakov commented Feb 23, 2023

/werft run with-preview with-gce-vm

👍 started the job as gitpod-build-ak-code-validate.3
(with .werft/ from main)

@akosyakov akosyakov marked this pull request as ready for review February 23, 2023 14:16
@akosyakov akosyakov requested a review from a team February 23, 2023 14:16
@akosyakov
Copy link
Member Author

akosyakov commented Feb 23, 2023

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-ak-code-validate.6
(with .werft/ from main)

@filiptronicek
Copy link
Member

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, everything looks like working well -- I get both the notifications on save and the context menu options.

There's just one small bug that happens when you create a .gitpod.yml not in the project root - you can still see all the options, although if you decide to act on them and Validate, it will use the root .gitpod.yml, which users may not expect. I think we should disable context menus for non-root .gitpod.ymls. Let's talk about this async if even

image

@filiptronicek
Copy link
Member

/unhold

@roboquat roboquat merged commit 26c520c into main Feb 23, 2023
@roboquat roboquat deleted the ak/code_validate branch February 23, 2023 15:52
@akosyakov
Copy link
Member Author

There's just one small bug that happens when you create a .gitpod.yml not in the project root - you can still see all the options, although if you decide to act on them and Validate, it will use the root .gitpod.yml, which users may not expect. I think we should disable context menus for non-root .gitpod.ymls. Let's talk about this async if even

We should provide --workspace-folder then, but I won't do anything for now.

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt user to use gp rebuild after updating their .gitpod.yml or Docker configuration.
3 participants