Skip to content

[ws-manager-mk2] Refactor metric collection and add tests #16585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

WVerlaek
Copy link
Member

Description

  • Refactor how metrics are recorded. Fixes some condition changes being ignored.
    • Instead of only checking for metric updates on a workspace's phase change, now keep track of a struct per workspace that contains which conditions have been recorded, and diff on each reconcile. This ensures we notice a condition change even when the phase doesn't change
  • Add unit testing for metrics

Related Issue(s)

Part of #11416

How to test

cd components/ws-manager-mk2
go test ./...

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Feb 27, 2023
@WVerlaek WVerlaek requested a review from a team February 27, 2023 12:51
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 27, 2023
@roboquat roboquat merged commit e07b0c8 into main Mar 1, 2023
@roboquat roboquat deleted the wv/mk2-metrics-tests branch March 1, 2023 11:17
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants