Skip to content

[ws-manager-mk2] Add duration validation #16687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Mar 6, 2023

Description

Add validation on the duration field. The format=duration annotation is too lenient and still accepts some duration formats that can't be parsed by time.ParseDuration, so instead we can set a regex as described in kubernetes/apiextensions-apiserver#56

Fixes an invalid duration breaking the controller list/watch, stopping reconciliation of all workspace resources.

Related Issue(s)

Part of #11416

How to test

In a preview env:

  • gp set timeout 2h, try for various timeout values/units, and observe all succeed
  • kubectl edit workspace <name> and manually set an invalid timeout value in spec.timeout.time, and check that the update gets rejected by the API server

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek requested a review from a team March 6, 2023 13:31
@WVerlaek WVerlaek self-assigned this Mar 6, 2023
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 6, 2023
@roboquat roboquat merged commit 311da73 into main Mar 6, 2023
@roboquat roboquat deleted the wv/mk2-duration-validation branch March 6, 2023 17:39
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants